casaroli opened a new pull request, #20026: URL: https://github.com/apache/nuttx/pull/20026
## Summary Part 5.75 of the split of #19673, and only formatting. `libs/libc/machine/arm/armv7-m/arch_elf.c` and its armv8-m twin put the body of the relocation switch at the same indent as the switch braces. nxstyle reports forty-four errors in each: ``` $ tools/nxstyle libs/libc/machine/arm/armv7-m/arch_elf.c | wc -l 44 ``` CI feeds nxstyle the diff hunks with three lines of context, so any patch whose hunks land near them fails the check job through no fault of its own. `[6/10]` adds the `R_ARM_FUNCDESC` cases to those switches, so its hunks land throughout. This clears the way rather than making that PR carry the reformat. Giving the switch body its level takes the bit diagrams in the comments one column past the line limit. Three things follow from that: - the bit rulers say `Instr` rather than `Instructions`, which is enough and is what the same rulers further down the file already do - one annotation that had no code on its line becomes a sentence of its own, since nxstyle wants a blank line before a standalone comment - two comments that were a column out of line before are put right ## Impact None. Whitespace and comments. ## Testing Both files are clean afterwards: ``` $ tools/nxstyle libs/libc/machine/arm/armv7-m/arch_elf.c $ tools/nxstyle libs/libc/machine/arm/armv8-m/arch_elf.c ``` Compiled each file before and after, for cortex-m7 and cortex-m33, and compared the disassembly: ``` armv7-m: disassembly identical armv8-m: disassembly identical ``` `mps3-an547:picostest` builds. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
