xiaoxiang781216 commented on code in PR #20028:
URL: https://github.com/apache/nuttx/pull/20028#discussion_r3903654837
##########
arch/sim/src/sim/sim_uart.c:
##########
@@ -622,7 +622,12 @@ static void tty_dmareceive(struct uart_dev_s *dev)
{
xfer->nbytes = ret;
- if (ret == xfer->length && xfer->nlength > 0)
+ /* The console fd is blocking, so only continue into the wrapped
Review Comment:
but the code should work with non-block mode already:
https://github.com/apache/nuttx/blob/master/arch/sim/src/sim/posix/sim_hostuart.c#L119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
