raiden00pl commented on code in PR #20046:
URL: https://github.com/apache/nuttx/pull/20046#discussion_r3921862591
##########
sched/wqueue/kwork_cancel.c:
##########
@@ -71,6 +72,10 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue,
bool sync,
work_timer_reset(wqueue);
}
}
+ else
+ {
+ ret = -ENOENT;
Review Comment:
early return will change the behavior of this function for sync path. I
haven't analyzed the consequences of this, so no early return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
