acassis commented on PR #20092: URL: https://github.com/apache/nuttx/pull/20092#issuecomment-5590441761
> > We should check this in CI somewhere, this is the second exactly same issue in relatively short time (see #19142). `kconfiglib` doesn't have the issue, so standard CI build can't discover this and it's obviously hard to notice for developers that don't use `kconfig-frontends`. > > We can add `insert_final_newline = true` to Kconfig section in `.editoconfig` file and then use `editorconfig-checker` in CI to check it. > > ```diff > @@ -18,9 +18,10 @@ indent_brace_style = GNU > indent_style = tab > [Make.defs] > indent_style = tab > [Kconfig] > indent_style = tab > +insert_final_newline = true > > [*.sh] > indent_style = tab > max_line_length = 80 > ``` > > Anyone experienced with how to add new linter to NuttX CI? I think we need to test if this .editconfig will work with default kconfig-frontend and kconfig-lib (since we support both). Hey @simbit18 do you have some suggestions here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
