casaroli opened a new pull request, #20093:
URL: https://github.com/apache/nuttx/pull/20093

   ## Summary
   
   Two things in the NXFLAT documentation are no longer true.
   
   The download link is dead. `bitbucket.org/nuttx/buildroot` returns 404; the 
buildroot that still carries `ldnxflat` is 
[patacongo/buildroot](https://github.com/patacongo/buildroot).
   
   The instructions also ask for more than is needed. `mknxflat` came in tree 
with #19600, so only `ldnxflat` has to be built, and an ordinary 
`arm-none-eabi` GCC compiles and links NXFLAT modules — a board does not have 
to select `CONFIG_ARM_TOOLCHAIN_BUILDROOT` to use them. The page still 
described building the whole buildroot toolchain through `make menuconfig`.
   
   What `ldnxflat` does need, and what the page did not say, is a binutils 
source tree and a binutils build of the same version, because it reads its 
input through libbfd.
   
   The CI test list carried the same stale claim: 
`tools/ci/testlist/arm-06.dat` says the container lacks `mknxflat`. It lacks 
`ldnxflat`; `mknxflat` is built from `tools/nxflat` whenever `CONFIG_NXFLAT` is 
set.
   
   ## Impact
   
   Documentation and one comment. No code, no configuration.
   
   ## Testing
   
   Verified by doing it: `ldnxflat` built from `patacongo/buildroot` against 
binutils 2.43 libbfd, and `lm3s6965-ek:qemu-nxflat` built with the stock 
`arm-none-eabi` GCC 15.3 rather than the buildroot toolchain, with 
`CONFIG_ARM_TOOLCHAIN_GNU_EABI` in place of `CONFIG_ARM_TOOLCHAIN_BUILDROOT`. 
It runs under `qemu-system-arm -M lm3s6965evb`: the `errno` and `hello` NXFLAT 
tests pass.
   
   `tools/checkpatch.sh -c -u -m -g` passes.
   
   ## Note
   
   The dead Bitbucket URL appears about forty more times across 
`Documentation/`, for the AVR, HC, MISOC and LPC31xx boards that use the 
buildroot toolchain for other reasons. Those are left alone here; this changes 
only what NXFLAT says.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to