casaroli commented on code in PR #3762: URL: https://github.com/apache/nuttx-apps/pull/3762#discussion_r3966368538
########## testing/fs/xipfs/missingsym_bin.h: ########## @@ -20,181 +20,871 @@ * ****************************************************************************/ -/* Generated from missingsym.fdpic -- do not edit. Review Comment: I think it is not good idea because not every developer will have the supported binutils like we have in the CI image. So anyone wanting to run the tests will need it. If we want, we could check that the files match the binaries, in case anyone change the sources and forgets to update the binaries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
