NevynUK commented on code in PR #20125: URL: https://github.com/apache/nuttx/pull/20125#discussion_r4006454842
########## arch/risc-v/src/common/espressif/Make.defs: ########## @@ -39,6 +39,14 @@ CHIP_CSRCS += esp_irq.c esp_gpio.c esp_rtc_gpio.c esp_libc_stubs.c CHIP_CSRCS += esp_lowputc.c esp_serial.c CHIP_CSRCS += esp_systemreset.c +ifeq ($(CONFIG_ESPRESSIF_KERNEL_OWNS_PMP),y) Review Comment: Circular definitions, from the kconfig file: ``` A protected build requires this and must set it explicitly in its defconfig; esp_start.c fails the build if the two disagree. It is deliberately not "default y if BUILD_PROTECTED": this symbol selects ARCH_USE_MPU, BUILD_PROTECTED depends on ARCH_USE_MPU, and a default conditioned on BUILD_PROTECTED closes that loop. Kconfig resolves the circularity by making BUILD_PROTECTED unsatisfiable, which silently collapses the whole "Memory organization" choice for every board in the tree. ``` Does this help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
