btashton commented on a change in pull request #1762:
URL: https://github.com/apache/incubator-nuttx/pull/1762#discussion_r487170723
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss no that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss now that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss no that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss now that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss no that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss now that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss no that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss now that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss no that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss now that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss no that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss now that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss no that GitHub has made
cache faster.
##########
File path: .github/workflows/build.yml
##########
@@ -121,7 +121,7 @@ jobs:
uses: actions/cache@v2
with:
path: sources
- key: build-sources-${{ github.run_id }}
+ key: build-sources-${{ github.run_id }}-${{ github.run_number }}
Review comment:
We need to just drop the cache. We always miss now that GitHub has made
cache faster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
