xiaoxiang781216 commented on code in PR #20102:
URL: https://github.com/apache/nuttx/pull/20102#discussion_r4014655629


##########
.gitignore:
##########
@@ -95,3 +95,4 @@ SAVEconfig
 .aider*
 imx9-norimage.img
 config.txt
+CMakeUserPresets.json

Review Comment:
   revert



##########
CMakeLists.txt:
##########
@@ -97,6 +97,42 @@ if(EXISTS "${NUTTX_DIR}/.config")
     FATAL_ERROR "Please distclean previous make build with `make distclean`")
 endif()
 
+# Check if board presets already exist

Review Comment:
   remove, if you want to improve cmake build system, split to the new pr



##########
CMakePresets.json:
##########
@@ -0,0 +1,19 @@
+{

Review Comment:
   remove



##########
tools/generate_cmake_presets.py:
##########
@@ -0,0 +1,60 @@
+#!/usr/bin/env python3

Review Comment:
   revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to