daniel-p-carvalho commented on code in PR #3782:
URL: https://github.com/apache/nuttx-apps/pull/3782#discussion_r4030230819
##########
netutils/ptpd/ptpd.c:
##########
@@ -861,7 +861,25 @@ static int ptp_sendmsg(FAR struct ptp_state_s *state, FAR
const void *buf,
if (sendts != NULL)
{
+#ifdef SIOCG_TX_HW_TIMESTAMP
+ struct ifreq req;
Review Comment:
Agreed, SO_TIMESTAMPING + MSG_ERRQUEUE is the right long-term direction here
- it matches the discussion on the companion kernel PR (apache/nuttx#20148),
where we're holding off migrating SIOCG_TX_HW_TIMESTAMP until
apache/nuttx#20161 merges. Once that lands we'll migrate this ioctl to the same
mechanism in both PRs for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
