daniel-p-carvalho opened a new pull request, #20210:
URL: https://github.com/apache/nuttx/pull/20210

   ## Summary
   
   `ETH_MTLOMR_DTXSTS`, the Drop Transmit Status field of the MTL operation 
mode register of the STM32H7 Ethernet MAC, is defined as bit 0 in 
`arch/arm/src/stm32h7/hardware/stm32_ethernet.h`. In the reference manual and 
in the device header of ST (`ETH_MTLOMR_DTXSTS_Pos`) it is bit 1, and bit 0 is 
not used. This PR moves the definition to bit 1.
   
   I found it comparing the fields of this header with the device header of ST 
for the STM32H743: of the fields that have the same name in both, this one and 
`ETH_MACPFR_PM` (which is only named differently, `PR` in ST) were the only 
ones that did not match.
   
   ## Impact
   
   Nothing in the tree uses `ETH_MTLOMR_DTXSTS`, so the behaviour does not 
change. The definition is only correct for whoever uses it next.
   
   ## Testing
   
   The position was checked against the device header of ST (`stm32h743xx.h`). 
Only a constant changes and no code refers to it. `./tools/checkpatch.sh` 
passes. The change was not built on its own: the same header is compiled on 
hardware in other work, but with this line unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to