casaroli commented on code in PR #20368:
URL: https://github.com/apache/nuttx/pull/20368#discussion_r4121214684
##########
binfmt/Kconfig:
##########
@@ -66,6 +66,7 @@ config FDPIC
default n
select PIC
depends on ARCH_HAVE_ELF_FDPIC
+ depends on BUILD_FLAT
Review Comment:
well, FDPIC is only working on flat builds so far, no protected or kernel.
I will remove this from here and leave it broken in protected build. Then
make it work on a follow-up PR.
##########
libs/libc/elf/elf.h:
##########
@@ -255,6 +255,17 @@ int libelf_freebuffers(FAR struct mod_loadinfo_s
*loadinfo);
*
****************************************************************************/
+/****************************************************************************
Review Comment:
done
##########
libs/libc/elf/elf_symbols.c:
##########
@@ -93,8 +93,8 @@ extern int nglobals;
*
****************************************************************************/
-static int libelf_symname(FAR struct mod_loadinfo_s *loadinfo,
- FAR const Elf_Sym *sym, Elf_Off sh_offset)
+int libelf_symname(FAR struct mod_loadinfo_s *loadinfo,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
