btashton commented on a change in pull request #1778: URL: https://github.com/apache/incubator-nuttx/pull/1778#discussion_r487999097
########## File path: boards/arm/nrf52/nrf52-feather/Kconfig ########## @@ -5,4 +5,54 @@ if ARCH_BOARD_NRF52_FEATHER -endif +menuconfig NRF52_FEATHER_KB_FEATHERWING + bool "Keyboard FeatherWing" + default n + ---help--- + Enable support for the SolderParty FeatherWing + https://www.solder.party/docs/keyboard-featherwing/ + +if NRF52_FEATHER_KB_FEATHERWING +config KB_FEATHERWING_LCD Review comment: > One question: The use of the FeatherWing does not depend on NRF really. It could be selected for any Feather board potentially. So I wonder if this does not below in drivers/lcd and if it should not be named LCD_FEATHER_KB_FEATHERWING. > If we do that what would the difference be between LCD_FEATHER_KB_FEATHERWING and LCD_ILI9341? Seems like this would belong in `boards/` maybe in an expansion boards folder where there would be Kconfigs for different addon hardware for devkits? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
