xiaoxiang781216 commented on code in PR #3808: URL: https://github.com/apache/nuttx-apps/pull/3808#discussion_r4183139695
########## graphics/uGLy/CMakeLists.txt: ########## @@ -0,0 +1,133 @@ +# ############################################################################## +# apps/graphics/lvgl/CMakeLists.txt Review Comment: lvgl->uGLy ########## graphics/uGLy/Make_uGLy.defs: ########## @@ -20,14 +20,14 @@ # ############################################################################ -include $(APPDIR)/Make.defs +DEPPATH += --dep-path uGLy +VPATH += :uGLy -# ZBus message bus library (Zephyr zbus port) +CSRCS += es10cl.c es11.c matricesFP.c raster.c +CSRCS += fpsqrt.c -CSRCS = zbus.c zbus_iterable_sections.c +DEPPATH += --dep-path uGLy/src +DEPPATH += --dep-path uGLy/third_party/fpsqrt -ifneq ($(CONFIG_ZBUS_RUNTIME_OBSERVERS),) -CSRCS += zbus_runtime_observers.c -endif - -include $(APPDIR)/Application.mk +VPATH += :uGLy/src +VPATH += :uGLy/third_party/fpsqrt Review Comment: merge into Makefile ########## examples/uGLy_demo/CMakeLists.txt: ########## @@ -0,0 +1,33 @@ +# ############################################################################## +# apps/examples/fb/CMakeLists.txt Review Comment: correct all path ########## examples/uGLy_demo/tri.c: ########## @@ -1,305 +1,297 @@ -/* File based on https://gitlab.freedesktop.org/mesa/demos/-/blob/main/src/egl/opengles1/tri.c?ref_type=heads - * Please visit the original to see some proper code ;) - */ - -/* - * Copyright (C) 2008 Brian Paul All Rights Reserved. +/**************************************************************************** + * apps/examples/uGLy_demo/tri.c Review Comment: merge to demo patch too ########## graphics/uGLy/Make_uGLy.defs: ########## @@ -1,5 +1,5 @@ ############################################################################ -# apps/system/zbus/Makefile +# apps/graphics/pdcurs34/pdcurses/Make.defs Review Comment: fix the path ########## graphics/uGLy/Makefile: ########## @@ -0,0 +1,76 @@ +############################################################################ +# apps/graphics/uGLy/Makefile +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +include $(APPDIR)/Make.defs + +# uGLy graphic library + +# Set up build configuration and environment + +WD := ${shell echo $(CURDIR) | sed -e 's/ /\\ /g'} + +CONFIG_GRAPH_UGLY_URL ?= "https://github.com/TheFakeMontyOnTheRun/uGLy/archive/refs/tags"; + +_MAJ := $(CONFIG_UGLY_VERSION_MAJOR) Review Comment: where we define CONFIG_UGLY_VERSION_xxx ########## graphics/uGLy/CMakeLists.txt: ########## @@ -0,0 +1,133 @@ +# ############################################################################## +# apps/graphics/lvgl/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ############################################################################## + +if(CONFIG_GRAPHICS_LVGL) + + # ############################################################################ + # Config and Fetch lvgl + # ############################################################################ + set(LVGL_DIR ${CMAKE_CURRENT_LIST_DIR}/lvgl) Review Comment: correct cmake ########## examples/uGLy_demo/internal.h: ########## @@ -104,8 +104,8 @@ void drawPoint(int* coords, uint8_t* colour, #define MAX(v1, v2) (( (v1) > (v2) ) ? (v1) : (v2) ) -#define XRES_FRAMEBUFFER 80 -#define YRES_FRAMEBUFFER 160 +#define XRES_FRAMEBUFFER 320 +#define YRES_FRAMEBUFFER 240 Review Comment: merge into the patch which add demo initially ########## examples/uGLy_demo/CMakeLists.txt: ########## @@ -0,0 +1,33 @@ +# ############################################################################## +# apps/examples/fb/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more contributor +# license agreements. See the NOTICE file distributed with this work for +# additional information regarding copyright ownership. The ASF licenses this +# file to you under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. +# +# ############################################################################## + +if(CONFIG_EXAMPLES_FB) Review Comment: ditto ########## graphics/uGLy/Makefile: ########## @@ -34,7 +34,7 @@ _MAJ := $(CONFIG_UGLY_VERSION_MAJOR) _MIN := $(CONFIG_UGLY_VERSION_MINOR) _PAT := $(CONFIG_UGLY_VERSION_PATCH) UGLY_VERSION := $(_MAJ).$(_MIN).$(_PAT) -UGLY_TARBALL := test-alan.zip +UGLY_TARBALL := test-for-0.1.zip Review Comment: please reorg your pr to merge the temp patch to original one ########## graphics/uGLy/Make.defs: ########## @@ -28,4 +28,9 @@ CONFIGURED_APPS += $(APPDIR)/graphics/uGLy CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/graphics/uGLy Review Comment: should we remove this path ########## graphics/uGLy/patches/0001-internal.h-allow-the-framebuffer-size-to-be-set-by-t.patch: ########## @@ -0,0 +1,41 @@ +From 944fe2eb78fe931cffca8cb6a942bcaa541ad8fc Mon Sep 17 00:00:00 2001 +From: Alan Carvalho de Assis <[email protected]> +Date: Wed, 16 Sep 2026 15:15:47 -0300 +Subject: [PATCH 1/2] internal.h: allow the framebuffer size to be set by the + build system + +XRES_FRAMEBUFFER and YRES_FRAMEBUFFER were hardcoded per platform, so +a port whose display is not 256x267 had to edit internal.h. Only use +the built-in defaults when the build system does not provide both +values (e.g. -DXRES_FRAMEBUFFER=320 -DYRES_FRAMEBUFFER=240). + +Signed-off-by: Alan C. Assis <[email protected]> +--- + include/internal.h | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/include/internal.h b/include/internal.h +index 175215f..7ffa2a0 100644 +--- a/include/internal.h ++++ b/include/internal.h +@@ -13,6 +13,12 @@ + + typedef void ( *KeyCallback )(int charkey); + ++/* The framebuffer size can be provided by the build system, e.g.: ++ * -DXRES_FRAMEBUFFER=320 -DYRES_FRAMEBUFFER=240 ++ */ ++#if !defined(XRES_FRAMEBUFFER) || !defined(YRES_FRAMEBUFFER) ++#undef XRES_FRAMEBUFFER ++#undef YRES_FRAMEBUFFER + #ifdef DOS Review Comment: why need? sim doesn't support DOS at all. ########## graphics/uGLy/patches/0002-src-nuttx.c-add-a-NuttX-framebuffer-backend.patch: ########## @@ -0,0 +1,426 @@ +From caba3d9b60e3d3a445b8e7968fc1cb212b297f14 Mon Sep 17 00:00:00 2001 +From: Alan Carvalho de Assis <[email protected]> +Date: Wed, 16 Sep 2026 15:16:32 -0300 +Subject: [PATCH 2/2] src/nuttx.c: add a NuttX framebuffer backend Review Comment: merge to the first patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
