casaroli opened a new pull request, #20486:
URL: https://github.com/apache/nuttx/pull/20486

   ## Summary
   
   `board_spisd_initialize()` logged `ERROR: Failed to mount the SDCARD` at 
every boot when there was no card in the slot. A missing card, or a card with 
no filesystem, is not an error: the block device is registered, and the card 
can be formatted with `mkfatfs` and mounted later.
   
   This PR logs `-EINVAL` and `-ENODEV` from `nx_mount()` at info level. Other 
errors are still logged at error level. It also includes `errno.h`, which the 
file used without including it.
   
   ## Impact
   
   Log output of rp23xx boards with `CONFIG_RP23XX_SPISD`. No functional change.
   
   ## Testing
   
   Arm GNU Toolchain 13.2.rel1 (the CI version). `tools/checkpatch.sh -c -u -m 
-g` passes.
   
   On a Pimoroni Pico Plus 2 W with no card, `pimoroni-pico-plus-2-w:nsh` with 
SPI0 on GPIO 2-5, `CONFIG_RP23XX_SPISD` and 
`CONFIG_DEBUG_ERROR`/`CONFIG_DEBUG_INFO`. The boot log before this PR:
   
   ```
   board_spisd_initialize: ERROR: Failed to mount the SDCARD. -19
   ```
   
   and after it:
   
   ```
   board_spisd_initialize: No filesystem on /dev/mmcsd0 (no card, or 
unformatted)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to