casaroli opened a new pull request, #3813:
URL: https://github.com/apache/nuttx-apps/pull/3813

   ## Summary
   
   apache/nuttx#20492 gives each task group its own registry of ELF objects. A 
library that a module names in `DT_NEEDED` is then loaded once per task group, 
not once for the system, so two instances of a module have two copies of the 
library data. The library text in xipfs is still shared.
   
   This changes the C++ test in `testing/fs/xipfs` and `examples/fdpicxip` to 
check this: the library is pinned twice while both instances run, its 
destructor runs once per instance, and each destructor sees only the adds of 
its own instance. The module sources change in comments only, so the embedded 
blobs do not change.
   
   The first commit fixes an nxstyle error that is already on master in 
`xipfs_main.c`, because CI checks the whole file. Whitespace only.
   
   ## Impact
   
   Tests and examples only. Merge after apache/nuttx#20492.
   
   depends-on: apache/nuttx/pull/20492
   
   ## Testing
   
   QEMU `mps2-an500:xipfs` with FDPIC and apache/nuttx#20492: `xipfs_test 
fdpic` gives 32 passed and 2 failed. The same 2 failures occur on master. 
`fdpicxip solib` and `fdpicxip cxx` show 2 pins while both instances run and 0 
after they exit. `tools/checkpatch.sh -c -u -m -g` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to