jsanchez-2g opened a new pull request, #20518:
URL: https://github.com/apache/nuttx/pull/20518

   ## Summary
   
   STM32H7 omits `stm32_lsi.c` when both `CONFIG_STM32_IWDG=y` and 
`CONFIG_STM32_RTC_LSICLOCK=y`. `$(filter y,...)` returns `y y`, which fails the 
existing equality comparison with `y`; calls to `stm32_rcc_enablelsi()` then 
lack their implementation.
   
   Replace the equality comparison with a nonempty-result test. The helper is 
selected once when either or both consumers are enabled, and omitted when 
neither is enabled. No Apps dependency.
   
   ## Impact
   
   Fixes build source selection for STM32H7. No new feature, API, configuration 
option, clock policy, watchdog policy, build procedure, user migration, 
documentation requirement, or intended security change. Existing 
single-consumer configurations retain their behavior.
   
   ## Testing
   
   Evaluated the actual Apache `arch/arm/src/stm32h7/Make.defs` and its 
included files using GNU Make before and after the change:
   
   ```text
   IWDG  RTC_LSICLOCK   before             after
   n     n             not selected       not selected
   y     n             stm32_lsi.c        stm32_lsi.c
   n     y             stm32_lsi.c        stm32_lsi.c
   y     y             not selected       stm32_lsi.c
   ```
   
   The identical change was also used in hardware-accepted Conductor 
checkpoint-06 build 866 (STM32H743BI, out-of-tree 
conductor:G005251/conductor_lua_eth). Its archived resolved configuration 
enables both consumers. The serial build completed compilation and linking with 
arm-none-eabi-gcc 13.2.1 on Linux x86_64; the board operator confirmed hardware 
acceptance on 2026-10-07. Both configuration and build logs are preserved 
locally.
   
   That image contains other 2G integration changes and local patches; it is 
not a full build of this isolated Apache contribution. Hardware acceptance is 
user-reported; no passing serial capture was supplied. No pristine-Apache 
full-build or hardware test is claimed.
   
   ## PR verification Self-Check
   
   - [x] One functional change.
   - [x] Summary, impact, and test scope described.
   - [x] Human sign-off and final commit-message check complete.
   - [ ] Work in progress.
   - [x] Ready for review; testing scope and limitations are disclosed above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to