casaroli opened a new pull request, #20536:
URL: https://github.com/apache/nuttx/pull/20536

   ## Summary
   
   `libs/libc/machine/arm/arch_mcount.S` selects the ARMv6-M code with 
`CONFIG_ARCH_CORTEXM0` and `CONFIG_ARCH_CORTEXM23`, but it did not include 
`nuttx/config.h`. So it always assembled the Thumb-2 code, and 
`CONFIG_PROFILE_MINI` did not build on Cortex-M0, M0+ and M23.
   
   This PR includes `nuttx/config.h`.
   
   ## Impact
   
   Only builds with `CONFIG_PROFILE_MINI`. On ARMv7-M and later the assembled 
code does not change.
   
   ## Testing
   
   Arm GNU Toolchain 13.2.rel1, `raspberrypi-pico:nsh` (Cortex-M0+) with 
`CONFIG_PROFILE_MINI=y`.
   
   Before:
   ```
   machine/arm/arch_mcount.S:48: Error: cannot honor width suffix -- `bic 
r1,r1,#1'
   machine/arm/arch_mcount.S:50: Error: cannot honor width suffix -- `bic 
r0,r0,#1'
   machine/arm/arch_mcount.S:52: Error: cannot honor width suffix -- `pop 
{r0,r1,r2,r3,ip,lr}'
   ```
   
   After: the build succeeds.
   
   `tools/checkpatch.sh -c -u -m -g` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to