cederom commented on issue #3418: URL: https://github.com/apache/nuttx-apps/issues/3418#issuecomment-6107606006
Thanks @Swatantra-66 yes please provide the PR with solution proposition :-) * MD5 is not considered secure, we should use SHA256+ where possible. * okay to replace `which` with `command -v`. * For now I would avoid Python in the `*.sh` scripts. We have clear separation of interpreters and dependencies. Python became moving target while shell is stable. We may want to fallback to pythoh when we hit a wall with existing problem, or create a dedicated python script for that. For now please avoid mixing the Python in. * okay with lowercase hash comaprison. * okay with `CHECKHASH` centralization in `apps/Make.defs`. * okay with optional overrides. * okay with example implementation in `graphics/lvgl` and `system/zlib`. Thank you and have fun! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
