casaroli commented on code in PR #20565: URL: https://github.com/apache/nuttx/pull/20565#discussion_r4243264862
########## include/nuttx/fs/cookie.h: ########## @@ -0,0 +1,69 @@ +/**************************************************************************** + * include/nuttx/fs/cookie.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_FS_COOKIE_H +#define __INCLUDE_NUTTX_FS_COOKIE_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/compiler.h> + +#include <sys/types.h> + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +/* Definitions for custom stream operations with fopencookie. The + * implementation is as defined in Standard C library (libc). The only + * difference is that we use off_t instead of off64_t. This means + * off_t is int64_t if CONFIG_FS_LARGEFILE is defined and int32_t if not. + * + * These callbacks can either lead to custom functions if fopencookie is used + * or to standard file system functions if not. + * + * They are in their own header because stdio.h needs them, and a program + * of a kernel build must not see the rest of nuttx/fs/fs.h. + */ + +typedef CODE ssize_t cookie_read_function_t(FAR void *cookie, FAR char *buf, Review Comment: Done for `struct file_struct` and `struct streamlist`: both are now in nuttx/tls.h with the stream flags (I think you meant tls.h, next to `ta_streamlist`), and fs.h no longer has them. I also tried moving `cookie_io_functions_t` and its callback types to stdio.h, but that does not build: for kernel code and flat builds, stdio.h includes nuttx/lib/lib.h, which reaches nuttx/tls.h (lib.h → kmalloc.h → sched.h → tls.h) before stdio.h can define the types, and `struct file_struct` needs them. So they stay in the small nuttx/fs/cookie.h that both stdio.h and tls.h include. `FILE` stays an incomplete type in stdio.h. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
