dcgong2917 commented on code in PR #20662:
URL: https://github.com/apache/nuttx/pull/20662#discussion_r4278505310
##########
arch/arm/src/rtl8730e/CMakeLists.txt:
##########
@@ -180,20 +185,34 @@ function(ameba_build_lib lib obj_subdir srcs_var inc_var
out_target)
endfunction()
# ----------------------------------------------------------------------------
-# libameba_fwlib.a -- minimal fwlib subset needed by flash MTD + IPC (and the
-# WiFi IPC path). Built from SDK source with the amebasmart CA32 include set.
-# Linked only when FLASH_FS is enabled (mirrors ameba_board.mk).
+# libameba_fwlib.a -- minimal fwlib subset needed by the drivers whose SDK
+# support code is not in lib_rom.a. Built from SDK source with the amebasmart
+# CA32 include set. The set of sources and the conditions selecting them
mirror
+# AMEBA_FWLIB_SRCS in ameba_board.mk one for one, and so must the conditions
+# below: a config that links the archive (see AMEBA_EXTRA_LIBS) but does not
+# build it here links a stale archive left in the board tree by a previous
+# config, and fails on undefined fwlib symbols.
# ----------------------------------------------------------------------------
set(AMEBA_FWLIB_A ${AMEBA_PREBUILT_LIBS}/libameba_fwlib.a)
-if(CONFIG_RTL8730E_FLASH_FS OR CONFIG_RTL8730E_WIFI)
+if(CONFIG_RTL8730E_FLASH_FS
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
