v01d commented on a change in pull request #385:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/385#discussion_r489441647
##########
File path: Makefile
##########
@@ -152,13 +156,12 @@ endif # CONFIG_BUILD_KERNEL
dirlinks:
$(Q) $(MAKE) -C platform dirlinks TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"
-context_rest: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_context)
+context_all: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_context)
+register_all: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_register)
-context_serialize:
- $(Q) $(MAKE) -C builtin context TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"
Review comment:
I'm unsure we should remove the call to a target such as context for a
subdirectory because it is unused. context might someday be required in builtin
and it may not be trivial to understand it is not being invoked. These targets
are invoked for all subdirectories in NuttX, so let's keep it even while right
now it is not used.
From what I understand $(CONFIGURED_APPS) does not contain "builtin", so
unless you explicitly call it, it will not be called at all. Just add "builtin"
instead the foreach of the context target. That will be enough I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
