casaroli opened a new pull request, #20792: URL: https://github.com/apache/nuttx/pull/20792
## Summary libc has `popen()`, `pclose()`, `dpopen()` and `dpclose()` (apache/nuttx#20778), so the copy in `apps/system/popen` is not needed any more. This PR disables `CONFIG_SYSTEM_POPEN` in the 15 configurations that enable it, and enables `CONFIG_SCHED_WAITPID` (which `CONFIG_SYSTEM_POPEN` selected) and `CONFIG_LIBC_EXECFUNCS` where they did not have it. Their users of `popen()` stay enabled: the fastboot shell command and the popen example (apache/nuttx-apps#3877 lets them take the libc copy). depends-on: [apache/nuttx/pull/20778 apache/nuttx-apps/pull/3877] ## Impact These configurations use the libc `popen()`. The apps options `CONFIG_SYSTEM_POPEN_STACKSIZE` and `CONFIG_SYSTEM_POPEN_PRIORITY` no longer apply; libc starts the command with the `posix_spawn()` defaults. ## Testing With apache/nuttx#20778 and apache/nuttx-apps#3877: each of the 15 configurations was configured and normalized with `make savedefconfig` (the two `fastboot_usb` overlays edited by hand; their `usb_device` base already has `CONFIG_LIBC_EXECFUNCS` and `CONFIG_SCHED_WAITPID`). In all 15, `CONFIG_SYSTEM_POPEN` is off, `CONFIG_PIPES`, `CONFIG_LIBC_EXECFUNCS` and `CONFIG_SCHED_WAITPID` are on, and the popen users are the same as before. | Configuration | Result | |---|---| | `qemu-armv8a:fastboot` | builds; `CONFIG_SYSTEM_FASTBOOTD_SHELL=y`; libc `lib_popen.o`/`lib_dpopen.o` built, no `system/popen` object | | `lx_cpu:nsh`, `sabre-6quad:citest` | build with the libc copy | | `qemu-armv8a:nsh` + `CONFIG_TESTING_POPEN`, `popen_test` in QEMU | `=== Results: 0 failed ===` | `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
