casaroli opened a new pull request, #20795: URL: https://github.com/apache/nuttx/pull/20795
## Summary `drivers/usbmisc/fusb302.c` does not compile with `CONFIG_I2C_RESET`: the `I2C_RESET()` call in `fusb302_irqworker()` has no closing parenthesis. `SET_WAIT_MODE()` has one opening parenthesis too many, and its only user one closing parenthesis too many to match it. The first commit fixes both. The second commit fixes the older nxstyle errors of the file (layout only; one pair of braces around a single `break;`, which nxstyle requires). The unbalanced parentheses had stopped nxstyle from checking the rest of the function, so the file needs both commits to pass the CI check. ## Impact `fusb302.c` compiles with `CONFIG_I2C_RESET`. The code that the default configuration compiles does not change. ## Testing `stm32f4discovery:nsh` with `CONFIG_USBMISC`, `CONFIG_STM32_I2C1`, `CONFIG_FUSB302` and `CONFIG_I2C_RESET`: | | master | this PR | |---|---|---| | build | fails: `fusb302.c:1336: error: expected ';' before ')' token` and 11 more errors | builds | For the layout commit: a token compare (comments and whitespace ignored) gives the same tokens except the added braces, and `objdump -d` of the object built before and after with `-D__LINE__=0` is identical. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
