casaroli opened a new pull request, #3879:
URL: https://github.com/apache/nuttx-apps/pull/3879

   ## Summary
   
   The poll() method of a driver takes `struct pollfd_s` from `nuttx/poll.h` 
after apache/nuttx#20796, where `struct pollfd` gets the POSIX layout and is 
only for user code. `testing/drivers/rpmsgdev/testdev.c` registers a driver 
with a poll method, so it follows the change.
   
   The first commit fixes older style errors that `tools/checkpatch.sh` reports 
in the file: the indentation of two switch statements and an if/else block, and 
the typo "regist" in the usage text. The code does not change.
   
   depends-on: apache/nuttx/pull/20796
   
   ## Impact
   
   `testdev.c` builds with the new `struct pollfd`. No change in behaviour.
   
   ## Testing
   
   `qemu-armv8a:rpserver` with `CONFIG_DEV_RPMSG`, `CONFIG_DEV_RPMSG_SERVER` 
and `CONFIG_RPMSGDEV_TEST`, against the nuttx PR: `testdev.c` compiles. The 
only compiler message is an older `-Wformat` warning at line 363 (`%d` for an 
`ssize_t`), which master also has on 64-bit targets. `tools/checkpatch.sh -c -u 
-m -g` passes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to