This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
commit ea8addeaf4ba7e28591f6f63df14e03003ebc68f Author: Marco Casaroli <[email protected]> AuthorDate: Mon Oct 19 00:07:29 2026 +0200 apps: Print the revents field of struct pollfd with %x. Five programs print the events of a struct pollfd with PRIx32. This format is correct only while the field is a 32-bit pollevent_t. POSIX gives the events and revents fields the type short. Cast the value to unsigned int and print it with %x, which is correct for both types. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <[email protected]> --- examples/poll/poll_listener.c | 10 +++++----- graphics/twm4nx/src/cinput.cxx | 8 ++++---- netutils/ptpd/ptpd.c | 4 ++-- netutils/thttpd/fdwatch.c | 5 +++-- testing/testsuites/kernel/socket/cases/net_socket_test_009.c | 4 ++-- 5 files changed, 16 insertions(+), 15 deletions(-) diff --git a/examples/poll/poll_listener.c b/examples/poll/poll_listener.c index e662c7231..61becb00b 100644 --- a/examples/poll/poll_listener.c +++ b/examples/poll/poll_listener.c @@ -145,15 +145,15 @@ void *poll_listener(pthread_addr_t pvarg) nevents = 0; for (i = 0; i < NPOLLFDS; i++) { - printf("poll_listener: FIFO revents[%d]=%08" PRIx32 "\n", i, - fds[i].revents); + printf("poll_listener: FIFO revents[%d]=%08x\n", i, + (unsigned int)fds[i].revents); if (timeout) { if (fds[i].revents != 0) { printf("poll_listener: ERROR? expected revents=00, " - "received revents[%d]=%08" PRIx32 "\n", - i, fds[i].revents); + "received revents[%d]=%08x\n", + i, (unsigned int)fds[i].revents); } } else if (pollin) @@ -165,7 +165,7 @@ void *poll_listener(pthread_addr_t pvarg) else if (fds[i].revents != 0) { printf("poll_listener: ERROR unexpected revents[%d]=" - "%08" PRIx32 "\n", i, fds[i].revents); + "%08x\n", i, (unsigned int)fds[i].revents); } } } diff --git a/graphics/twm4nx/src/cinput.cxx b/graphics/twm4nx/src/cinput.cxx index 2cbec3db1..60aef2aa2 100644 --- a/graphics/twm4nx/src/cinput.cxx +++ b/graphics/twm4nx/src/cinput.cxx @@ -818,8 +818,8 @@ int CInput::session(void) if ((pfd[KBD_INDEX].revents & (POLLERR | POLLHUP)) != 0) { - twmerr("ERROR: keyboard poll() failed. revents=%08" PRIx32 "\n", - pfd[KBD_INDEX].revents); + twmerr("ERROR: keyboard poll() failed. revents=%08x\n", + (unsigned int)pfd[KBD_INDEX].revents); ret = -EIO; break; } @@ -840,8 +840,8 @@ int CInput::session(void) if ((pfd[MOUSE_INDEX].revents & (POLLERR | POLLHUP)) != 0) { - twmerr("ERROR: Mouse poll() failed. revents=%08" PRIx32 "\n", - pfd[MOUSE_INDEX].revents); + twmerr("ERROR: Mouse poll() failed. revents=%08x\n", + (unsigned int)pfd[MOUSE_INDEX].revents); ret = -EIO; break; } diff --git a/netutils/ptpd/ptpd.c b/netutils/ptpd/ptpd.c index 7353fe5eb..395ca478a 100644 --- a/netutils/ptpd/ptpd.c +++ b/netutils/ptpd/ptpd.c @@ -1045,8 +1045,8 @@ static int ptp_get_tx_timestamp(FAR struct ptp_state_s *state, } else { - ptpwarn("PTP TX HWTS: poll ret=%d revents=0x%04" PRIx32 - " errno=%d\n", ret, pfd.revents, errno); + ptpwarn("PTP TX HWTS: poll ret=%d revents=0x%04x errno=%d\n", + ret, (unsigned int)pfd.revents, errno); } return ERROR; diff --git a/netutils/thttpd/fdwatch.c b/netutils/thttpd/fdwatch.c index dcbd782e5..35b73aab8 100644 --- a/netutils/thttpd/fdwatch.c +++ b/netutils/thttpd/fdwatch.c @@ -288,8 +288,9 @@ int fdwatch(struct fdwatch_s *fw, long timeout_msecs) { /* Yes... save it in a shorter list */ - fwinfo("pollndx: %d fd: %d revents: %08" PRIx32 "\n", - i, fw->pollfds[i].fd, fw->pollfds[i].revents); + fwinfo("pollndx: %d fd: %d revents: %08x\n", + i, fw->pollfds[i].fd, + (unsigned int)fw->pollfds[i].revents); fw->ready[fw->nactive++] = fw->pollfds[i].fd; if (fw->nactive == ret) diff --git a/testing/testsuites/kernel/socket/cases/net_socket_test_009.c b/testing/testsuites/kernel/socket/cases/net_socket_test_009.c index 7e497ffdb..0e2f005e2 100644 --- a/testing/testsuites/kernel/socket/cases/net_socket_test_009.c +++ b/testing/testsuites/kernel/socket/cases/net_socket_test_009.c @@ -183,8 +183,8 @@ static int handlereadfds(struct pollfd *fds, int nfds, int lsfd) continue; } - syslog(LOG_INFO, "[%d]revents: %04" PRIx32, fds[i].fd, - fds[i].revents); + syslog(LOG_INFO, "[%d]revents: %04x", fds[i].fd, + (unsigned int)fds[i].revents); if (fds[i].fd == lsfd) { ret += handleaccept(lsfd);
