xiaoxiang781216 commented on code in PR #20818: URL: https://github.com/apache/nuttx/pull/20818#discussion_r4316134017
########## include/nuttx/tls.h: ########## @@ -144,7 +144,6 @@ struct task_info_s #endif #ifndef CONFIG_BUILD_KERNEL struct getopt_s ta_getopt; /* Globals used by getopt() */ - mode_t ta_umask; /* File mode creation mask */ Review Comment: why not just move ta_umask out of `#ifndef CONFIG_BUILD_KERNEL` block? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
