raiden00pl commented on code in PR #20824:
URL: https://github.com/apache/nuttx/pull/20824#discussion_r4322898892


##########
include/nuttx/analog/pot.h:
##########
@@ -237,6 +237,43 @@ FAR struct pot_dev_s *mcp445x_initialize(FAR struct 
i2c_master_s *i2c,
                                          uint8_t addr, uint32_t rab);
 #endif
 
+/* MCP454X/MCP456X/MCP464X/MCP466X device types */
+
+#ifdef CONFIG_POT_MCP45XX
+enum mcp45xx_chip_e

Review Comment:
   move under "Public Types". nxstyle still doesn't catch issues like this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to