Swatantra-66 commented on PR #20787:
URL: https://github.com/apache/nuttx/pull/20787#issuecomment-6287538664
Hi @raiden00pl, thank you for the review All points have been addressed:
1. **`stm32f0l0g0` / `stm32`**: Removed from `common_dirs`. That was an
obsolete reference from prior to the #19143 directory split.
2. **`common/stm32` targeting**: Implemented! Any change touching
`arch/arm/src/common/stm32/` or `boards/arm/common/stm32/` (or cross-STM32
families) now sets the family to `arm-stm32`. This builds all 6 STM32
containers (`arm-stm32*`) while skipping all 7 non-STM32 containers (`arm-nxp`,
`arm-nrf`, `arm-sam`, `arm-imx`, `arm-ti`, `arm-rp2xxx`, `arm-other`).
3. **`uses: ./.github/workflows/arch.yml`**: In GitHub Actions, referencing
`@master` downloads the workflow from `apache/nuttx:master`, which ignores PR
changes to `arch.yml` during CI testing. Using `./.github/workflows/arch.yml`
allows GitHub Actions to test the updated `arch.yml` from this PR branch.
4. **Toolchain / Compiler Parity**: The toolchain flags have been completely
restored to 1:1 exact parity with `master` (`arm-01..14.dat`). Verified across
all 13 testlists:
Defconfigs: 1,226 in master, 1,226 in PR (0 additions, 0 deletions)
CMake targets: 209 in master, 209 in PR (0 additions, 0 deletions)
Blacklist: 14 in master, 14 in PR (0 additions, 0 deletions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
