xiaoxiang781216 commented on code in PR #3887: URL: https://github.com/apache/nuttx-apps/pull/3887#discussion_r4327340577
########## testing/ostest/ostest_main.c: ########## @@ -748,9 +748,10 @@ int main(int argc, FAR char **argv) int ostest_result = OK; #endif -#ifndef CONFIG_BUILD_KERNEL +#if !defined(CONFIG_BUILD_KERNEL) && !defined(CONFIG_DISABLE_ALL_SIGNALS) int result; #else +#ifdef CONFIG_BUILD_KERNEL Review Comment: why not change to: ``` #if defined(CONFIG_BUILD_KERNEL) #elif !defined(CONFIG_DISABLE_ALL_SIGNALS) #endif ``` ########## testing/ostest/ostest_main.c: ########## @@ -816,6 +818,22 @@ int main(int argc, FAR char **argv) show_environment(true, true, true); #endif + /* Verify that we can spawn a new task. If all signal support is disabled, + * execute the test body synchronously instead. This keeps ostest usable + * on configurations where waitpid()/SIGCHLD are intentionally unavailable. + */ + +#if defined(CONFIG_DISABLE_ALL_SIGNALS) && !defined(CONFIG_BUILD_KERNEL) Review Comment: change to: ··· #elif !defined(CONFIG_DISABLE_ALL_SIGNALS) ··· and move before line 857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
