casaroli commented on code in PR #3890: URL: https://github.com/apache/nuttx-apps/pull/3890#discussion_r4329028263
########## system/popen/Kconfig: ########## @@ -4,70 +4,14 @@ # config SYSTEM_POPEN Review Comment: `CONFIG_SYSTEM_POPEN` selected `CONFIG_SCHED_WAITPID` and `CONFIG_LIBC_EXECFUNCS`, so a defconfig from `make savedefconfig` with `CONFIG_SYSTEM_POPEN=y` does not contain these two options. If the option goes away, such a configuration loses `CONFIG_SCHED_WAITPID` without a message: libc does not build `popen()`, the fastboot shell command and the popen test and example are disabled, and programs that call `waitpid()`, for example `system/nxinit`, do not build. The stub keeps these configurations as they are. No defconfig in nuttx sets it any more (apache/nuttx#20792). If you prefer, I can remove the option in this PR and put a migration note in the description: "set `CONFIG_SCHED_WAITPID=y` and `CONFIG_LIBC_EXECFUNCS=y` in place of `CONFIG_SYSTEM_POPEN=y`". Or I can remove it in a later PR, after one release with the deprecated stub. Which do you want? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
