Sarthak-Pandey commented on code in PR #3859: URL: https://github.com/apache/nuttx-apps/pull/3859#discussion_r4329740982
########## interpreters/duktape/duk_cmdline.patch: ########## @@ -44,3 +124,33 @@ diff --color -ur duktape/src-noline/duk_config.h duktape-2.5.0-modifed/src-nolin -#define DUK_USE_DATE_PRS_STRPTIME +#undef DUK_USE_DATE_PRS_STRPTIME #define DUK_USE_DATE_FMT_STRFTIME + + #if 0 /* XXX: safe condition? */ +@@ -2962,7 +2962,17 @@ typedef struct duk_hthread duk_context; + #undef DUK_USE_EXEC_INDIRECT_BOUND_CHECK + #undef DUK_USE_EXEC_PREFER_SIZE + #define DUK_USE_EXEC_REGCONST_OPTIMIZE +-#undef DUK_USE_EXEC_TIMEOUT_CHECK ++#define DUK_USE_EXEC_TIMEOUT_CHECK(udata) duk_cmdline_timeout_check(udata) Review Comment: Done! Simplified duk_cmdline_timeout_check() to directly return g_interrupted; and removed g_executing. Updated the patch and force-pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
