casaroli commented on code in PR #3882: URL: https://github.com/apache/nuttx-apps/pull/3882#discussion_r4331084273
########## Make.defs: ########## @@ -23,6 +23,12 @@ TOPDIR ?= $(APPDIR)/import -include $(TOPDIR)/Make.defs +# Send the emulated TLS calls of loadable modules and of the programs of a +# kernel build to libc (EMUTLS_LDFLAGS: see tools/Config.mk of NuttX) + +LDELFFLAGS += $(EMUTLS_LDFLAGS) Review Comment: Done in apache/nuttx#20723: the arch `Toolchain.defs` (and the sim `Make.defs`) now adds `EMUTLS_LDFLAGS` to `LDELFFLAGS` and `LDMODULEFLAGS`, and `mkexport.sh` keeps it in the export. With apps master, a module that uses `__thread` now links to `__wrap___emutls_get_address` of libc (`tlsgroup: PASS` on `qemu-armv8a:nsh`), and the export of `qemu-armv8a:knsh` has the options. apps needs no change, so I close this PR. The boards that set these variables again in their `Make.defs` are cleaned up in apache/nuttx#20844. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
