XuNeo commented on code in PR #20460: URL: https://github.com/apache/nuttx/pull/20460#discussion_r4355504936
########## fs/procfs/fs_procfsuptime.c: ########## @@ -44,22 +44,13 @@ #include <nuttx/kmalloc.h> #include <nuttx/fs/fs.h> #include <nuttx/fs/procfs.h> +#include <nuttx/streams.h> #include "fs_heap.h" #if !defined(CONFIG_DISABLE_MOUNTPOINT) && defined(CONFIG_FS_PROCFS) #ifndef CONFIG_FS_PROCFS_EXCLUDE_UPTIME -/**************************************************************************** - * Pre-processor Definitions - ****************************************************************************/ - -/* Determines the size of an intermediate buffer that must be large enough - * to handle the longest line generated by this logic. - */ - -#define UPTIME_LINELEN 16 Review Comment: I saw mainly two issues/reasons: 1. procfs read needs an extra line buffer 2. procfs_snprintf requires caller manually processing offset of read buffer, and cause many usages issues. Some of them are just fixed in recent PRs. Issues like: https://github.com/apache/nuttx/pull/20256 https://github.com/apache/nuttx/pull/20326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
