Phil-Engljaehringer commented on PR #20890: URL: https://github.com/apache/nuttx/pull/20890#issuecomment-6367370838
@acassis @xiaoxiang781216 Sorry for the re-review. I pushed one small follow-up change, the rest is unchanged: - New `imx9_mu_enable_irq()` in `imx9_mu.c/.h`: only does the `irq_attach()` + `up_enable_irq()`. `imx9_mu_init()` now calls it. Its behaviour and order are unchanged. - `imx9_scmi_notify_register()` calls `imx9_mu_enable_irq(g_mudev)` instead of calling `imx9_mu_init(5)` a second time. `imx9_mu_init()` also clears the MU callbacks, so calling it again could silently drop a callback registered earlier. Nothing registers one on MU5 before this today, so it's a safety fix, not a behaviour change. Re-tested: checkpatch (`-c -u -m -g`) passes, `mr-navq95b:rpmsg` and `:nsh` build without warnings, and on hardware the LM2 shutdown/boot events still arrive on a Linux reboot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
