casaroli opened a new pull request, #20994: URL: https://github.com/apache/nuttx/pull/20994
## Summary #20950 added the `arm_fault_kill()` prototype to `arch/arm/src/armv7-a/arm.h`. The prototype uses `bool` and `uint32_t`, but `arm.h` did not include `<stdbool.h>` and `<stdint.h>`. `a1x_boot.c` includes `arm.h` before a header that defines `bool`, so `pcduino-a10:nsh` does not build on master: ``` arch/arm/src/armv7-a/arm.h:123:1: error: unknown type name 'bool' ``` This PR makes `arm.h` include the two headers, when it is not included from assembly. ## Impact Build fix only. No change to the generated code. Every armv7-a chip. ## Testing Build with `EXTRAFLAGS="-Wno-cpp -Werror"` (as in CI): | Config | master | this PR | |---|---|---| | `pcduino-a10:nsh` (flat, a1x) | `unknown type name 'bool'` | OK | | `qemu-armv7a:nsh` (flat) | not built | OK | | `qemu-armv7a:knsh` (kernel) | not built | OK | | `sabre-6quad:smp` (flat, SMP, i.MX6) | not built | OK | `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
