acassis commented on PR #21001:
URL: https://github.com/apache/nuttx/pull/21001#issuecomment-6414847057
@Fix-Point could you please test it in some real STM32 board with High
Resolution timer?
Seems like it wasn't well tested, probably you only tested it on QEMU, see:
```
Configuration/Tool: smartl-c906/sotest
2026-10-26 10:35:14
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
hrtimer.c: In function 'hrtimer_test_cancel_callback':
Error: hrtimer.c:364:31: error: implicit declaration of function
'spin_lock_irqsave' [-Wimplicit-function-declaration]
364 | irqstate_t flags = spin_lock_irqsave(lock);
| ^~~~~~~~~~~~~~~~~
Error: hrtimer.c:381:3: error: implicit declaration of function
'spin_unlock_irqrestore' [-Wimplicit-function-declaration]
381 | spin_unlock_irqrestore(lock, flags);
| ^~~~~~~~~~~~~~~~~~~~~~
Error: hrtimer.c:385:3: error: implicit declaration of function 'up_ndelay'
[-Wimplicit-function-declaration]
385 | up_ndelay(delay);
| ^~~~~~~~~
hrtimer.c: In function 'hrtimer_test':
Error: hrtimer.c:865:24: error: storage size of 'attr' isn't known
865 | pthread_attr_t attr;
| ^~~~
In file included from /github/workspace/sources/nuttx/include/time.h:31,
from /github/workspace/sources/nuttx/include/sys/time.h:32,
from /github/workspace/sources/nuttx/include/sys/timex.h:30,
from
/github/workspace/sources/nuttx/include/nuttx/clock.h:32,
from
/github/workspace/sources/nuttx/include/nuttx/hrtimer.h:31,
from hrtimer.c:28:
Error: hrtimer.c:872:10: error: implicit declaration of function
'pthread_attr_init' [-Wimplicit-function-declaration]
872 | ASSERT(pthread_attr_init(&attr) == 0);
| ^~~~~~~~~~~~~~~~~
Error: hrtimer.c:874:27: error: 'PTHREAD_DEFAULT_PRIORITY' undeclared (first
use in this function)
874 | sparam.sched_priority = PTHREAD_DEFAULT_PRIORITY;
| ^~~~~~~~~~~~~~~~~~~~~~~~
hrtimer.c:874:27: note: each undeclared identifier is reported only once for
each function it appears in
Error: hrtimer.c:875:10: error: implicit declaration of function
'pthread_attr_setschedparam'; did you mean 'posix_spawnattr_setschedparam'?
[-Wimplicit-function-declaration]
875 | ASSERT(pthread_attr_setschedparam(&attr, &sparam) == 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
Error: hrtimer.c:881:14: error: implicit declaration of function
'pthread_create'; did you mean 'timer_create'? [-Wimplicit-function-declaration]
881 | ASSERT(pthread_create(&pthreads[thread_id], &attr,
| ^~~~~~~~~~~~~~
Error: hrtimer.c:889:7: error: implicit declaration of function
'pthread_join'; did you mean 'pthread_kill'? [-Wimplicit-function-declaration]
889 | pthread_join(pthreads[thread_id], NULL);
| ^~~~~~~~~~~~
| pthread_kill
Error: hrtimer.c:894:10: error: implicit declaration of function
'pthread_attr_destroy' [-Wimplicit-function-declaration]
894 | ASSERT(pthread_attr_destroy(&attr) == 0);
| ^~~~~~~~~~~~~~~~~~~~
Error: hrtimer.c:865:24: error: unused variable 'attr'
[-Werror=unused-variable]
865 | pthread_attr_t attr;
| ^~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
