maxikrie opened a new pull request, #21006:
URL: https://github.com/apache/nuttx/pull/21006
## Summary
The XIAO nRF52840's RGB LED is active low (`board.h`: "A low output
illuminates the LED"), but `GPIO_LED1`-`GPIO_LED3` configured their pins with
`GPIO_VALUE_ZERO`, so all three colours lit as soon as the pins were
configured.
- With `USERLED` (e.g. `xiao-nrf52840:jumbo`) the LED showed white from boot
until an application first set it.
- With `ARCH_LEDS`, every state started from white rather than the pattern
listed in `board.h`.
This PR configures the pins high, i.e. off.
## Impact
- `xiao-nrf52840` only: the LED stays dark after boot until it is switched on
by `ARCH_LEDS` or an application.
- `LED_ON`/`LED_OFF` in `nrf52_autoleds.c` and `nrf52_userleds.c` are
unchanged. No Kconfig, API or build changes.
## Testing
Host: Debian Linux (kernel 6.1), x86_64.
Toolchain: `arm-none-eabi-gcc (Arm GNU Toolchain 13.3.Rel1) 13.3.1 20240614`
`xiao-nrf52840:nsh` and `xiao-nrf52840:jumbo` build without warnings
(CMake/Ninja). The patch passes `tools/checkpatch.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
