maxikrie opened a new pull request, #3926:
URL: https://github.com/apache/nuttx-apps/pull/3926
## Summary
- `examples/nimble_bleprph/CMakeLists.txt` named its app
`${CONFIG_EXAMPLES_NIMBLE_BLECENT_PROGNAME}` (copied from blecent). With
CMake, bleprph alone is built in as `blecent`, and enabling both
examples fails at configure time:
`add_library cannot create target "apps_blecent" because another target
with the same name already exists`.
- Neither example's CMakeLists.txt passed `PRIORITY` and `STACKSIZE`, which
their Makefiles take from `CONFIG_EXAMPLES_NIMBLE_BLE*_PRIORITY` /
`_STACKSIZE`; CMake builds used the defaults whatever was configured.
Make builds are not affected.
## Impact
CMake builds with `EXAMPLES_NIMBLE_BLEPRPH` and/or
`EXAMPLES_NIMBLE_BLECENT`.
## Testing
`nrf52840-dk:sdc_nimble` with CMake, both examples enabled, bleprph stack
6144 / priority 120, blecent stack 5120 (nuttx b9d1d6a834, nuttx-apps
e2d9f5cf1):
| | before | after |
|---|---|---|
| configure | fails (duplicate target `apps_blecent`) | ok |
| builtin list | — | `blecent` 100/5120, `bleprph` 120/6144 |
On an nRF52840-DK, `bleprph &` starts as `bleprph [6:120]` and registers
its GATT services. `tools/checkpatch.sh -f` passes on both files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
