cederom commented on code in PR #3929:
URL: https://github.com/apache/nuttx-apps/pull/3929#discussion_r4383700366
##########
testing/sched/timerjitter/timerjitter.c:
##########
@@ -192,8 +194,8 @@ static FAR void *timerjitter(FAR void *arg)
}
param->avg = 0;
- param->max = 0;
- param->min = (unsigned long)-1;
+ param->max = INT64_MIN;
Review Comment:
Questions here :-)
* why max is INT64_MIN not INT64_MAX?
* why min is INT64_MAX not INT64_MIN?
* why avg is 0 and of type double not int64_t like min and max?
* because min/max type change from unsigned long -> int64_t and no change in
double avg what happens then avg becomes negative number (i.e. min=-100,
max=10)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
