maxikrie commented on PR #21007: URL: https://github.com/apache/nuttx/pull/21007#issuecomment-6442847715
> what about STOP after NACK? When you use AI, you should double-check what it has produced, because sometimes it is lazy and miss details. > > EDIT: This fix real issue on master, later we could add RESUME + STOP on ERROR as improvement You're right, the driver never ends a transfer with STOP after an ERROR: it reports -ENXIO and returns, on master as well as with this PR. With the repeated START there's one more case, a NACK on the register byte, where LASTTX has already fired, so the LASTTXâSTARTRX shortcut can still start the read. I'll send a follow-up for nRF52/53/91 that triggers RESUME + STOP on ERROR and completes the transfer on STOPPED only, tested on the DKs with an address NACK and a NACK on the register byte. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
