ricardgb commented on PR #19250: URL: https://github.com/apache/nuttx/pull/19250#issuecomment-6442071864
@casaroli thanks, all addressed: - **Composite:** the board-local `rp23xx_composite.c` is gone. CDC-NCM is now in the common `rp23xx_composite.c`, after mass storage and CDC-ACM, on endpoints 6/7/8. The CDC-ACM block now also counts up `ifnobase`/`strbase`, which it didn't need to while it was last. A CMake build of `raspberrypi-pico-2-w:composite` now has `cdcncm_get_composite_devdesc` in the image, and on the board the host gets both `ttyACM0` and `usb0` (cdc_ncm). - **`composite` defconfig:** `CONFIG_COMPOSITE_IAD=y`, VID/PID `0x03eb`/`0x2022` like the other rp2xxx composite configs. It now enumerates as 03eb:2022, and the build has no warnings. - **`CONFIG_ALLOW_BSD_COMPONENTS`:** removed from both configs. - **Buttons:** `rp23xx_buttons.c`, the button definitions in `rp23xx_pico.h` and `board.h`, and the `/dev/buttons` registration in bring-up are removed. - **Commit format:** subjects end with `.`, and `Assisted-by:` uses the `AGENT_NAME:MODEL_VERSION` form above `Signed-off-by:`. The NCM change is now its own commit (`boards/arm/rp23xx/common: Add CDC-NCM to the composite device.`), separate from the board's `composite` configuration. Fresh test logs are in the description. --- *Prepared with the assistance of an AI agent (Claude Code) and human-reviewed.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
