casaroli commented on code in PR #20827: URL: https://github.com/apache/nuttx/pull/20827#discussion_r4392210342
########## include/nuttx/sched.h: ########## @@ -461,7 +461,9 @@ struct task_group_s pid_t tg_pid; /* The ID of the task within the group */ pid_t tg_ppid; /* This is the ID of the parent thread */ uint8_t tg_flags; /* See GROUP_FLAG_* definitions */ +#ifdef CONFIG_SCHED_CAPABILITIES Review Comment: This does not make the struct smaller: without `tg_caps` the padding before `mode_t tg_umask` grows from 2 to 3 bytes, so `sizeof(struct task_group_s)` stays the same. Fix: move `tg_caps` next to another small field, or drop the size claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
