casaroli commented on code in PR #20782: URL: https://github.com/apache/nuttx/pull/20782#discussion_r4392215572
########## drivers/timers/watchdog.c: ########## @@ -611,6 +607,190 @@ static ssize_t wdog_read(FAR struct file *filep, FAR char *buffer, return ret; } +#ifdef CONFIG_WATCHDOG_AUTOMONITOR_TASKS +/* Arm a channel, its timeout starts now. The lock must be held. */ + +static void watchdog_channel_arm(FAR struct watchdog_user_s *user) Review Comment: `WDIOC_START` (line 735), `WDIOC_STOP` (line 741) and `'V'` (line 704) still re-arm or disarm an expired channel, so a late task can make the monitor feed the hardware again. Fix: leave the channel unchanged in these paths when `user->armed && clock_compare(user->deadline, clock_systime_ticks())`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
