casaroli commented on code in PR #21040:
URL: https://github.com/apache/nuttx/pull/21040#discussion_r4392391383
##########
boards/tricore/tc4x/a3g-tc4d7-lite/scripts/Make.defs:
##########
@@ -42,3 +38,27 @@ CXXFLAGS := $(ARCHCXXFLAGS) $(ARCHOPTIMIZATION)
$(ARCHCPUFLAGS) $(ARCHXXINCLUDES
CXXPICFLAGS = $(ARCHPICFLAGS) $(CXXFLAGS)
CPPFLAGS := $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS)
AFLAGS := $(CFLAGS) -D__ASSEMBLY__
+
+OPENOCD ?= /opt/tooling/tricore-openocd/bin/openocd
+OPENOCD_SCRIPTS ?= /opt/tooling/tricore-openocd/share/openocd/scripts/
+OPENOCD_BOARD ?= board/infineon/kit_a3g_tc4d7_lite.cfg
+OPENOCD_SERIAL ?= AURIX LITE KIT V1.0 (TC4D7) LKAA9ZRG
Review Comment:
`OPENOCD_SERIAL` defaults to one specific kit, so `make flash` fails on
every other TC4D7 Lite Kit.
Fix: make the default empty.
##########
arch/tricore/Kconfig:
##########
@@ -121,26 +92,50 @@ config ARCH_MPU_CODE_NREGIONS
---help---
The code regions count
-config HAVE_SECURITY_CORE
- bool
+config ARCH_TRICORE_CPU_COUNT
Review Comment:
`ARCH_TRICORE_CPU_COUNT` is visible for TC3X, but the AMP code uses the TC4x
CPU SFR layout and `_flash_banks` from the TC4D7 scripts, so a TC3X config with
a count above 1 does not link.
Fix: `depends on ARCH_CHIP_FAMILY_TC4X` with a `range`, and move the AMP
code to `arch/tricore/src/tc4x/`.
##########
boards/tricore/tc4x/a3g-tc4d7-lite/scripts/tricore.ld:
##########
@@ -0,0 +1,184 @@
+#include <nuttx/config.h>
Review Comment:
This new file has no license header (also `tricore-llvm.ld` and
`tricore.lsl` in this directory).
Fix: add the Apache-2.0 header with the SPDX line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
