casaroli commented on code in PR #21001:
URL: https://github.com/apache/nuttx/pull/21001#discussion_r4396922263
##########
include/sys/tree.h:
##########
@@ -310,9 +301,7 @@ while (0)
SPLAY_ASSEMBLE(head, &__node, __left, __right, field); \
} \
\
- /* Splay with either the minimum or the maximum element \
- * Used to find minimum or maximum element in tree. \
- */ \
+ /* Splay with either the minimum or the maximum element Used to find minimum
or maximum element in tree. */ \
Review Comment:
This line has 111 columns (the limit is 78), and it joins two sentences
without a period.
Fix: `/* Splay to the minimum or the maximum element. */ \`
##########
sched/Kconfig:
##########
@@ -2174,4 +2175,23 @@ config HRTIMER_TREE
endchoice
+config HRTIMER_PRECISION_SHIFT
Review Comment:
`HRTIMER_PRECISION_SHIFT` is new, and `TIMER_ADJUST_USEC` is renamed to
`TIMER_ADJUST_NSEC` (the unit changes from us to ns), but Documentation does
not change. `Documentation/os/time/time_clock.rst` has the tickless options and
an HRTimer section.
Fix: add both options to `Documentation/os/time/time_clock.rst` in a
separate commit of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
