yf13 commented on code in PR #20996: URL: https://github.com/apache/nuttx/pull/20996#discussion_r4407335580
########## include/nuttx/compiler.h: ########## @@ -657,6 +657,8 @@ # define tz_nonsecure_call __attribute__((cmse_nonsecure_call)) # endif +# define CONFIG_HAVE_EXPRESSION_STATEMENT 1 Review Comment: This macro wont benefit in DEBUG_NOOPT so it is gated now by `DEBUG_FULLOPT` and `!64BIT` plus arch filters. Guess the compiler optimization may not work equally well on all archs. Using div64_const32() in ultoa_invert.c alone doesnt cut the dependency from `div_const()` macro to 64 bit GCC library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
