cederom commented on PR #20686: URL: https://github.com/apache/nuttx/pull/20686#issuecomment-6496489706
Regarding architecture: * @anchao I think more people here (i.e. me, @jerpelea, @acassis, @xiaoxiang781216, @linguini1, ..) asks for keeping ZBlue as "external module". * I know you prefer to keep it "internal" and "adapted with time" but this may make maintenance harder in future. * We can clone a given zblue commit, then use "glue" to make it work on NuttX. * That way we only adapt the "glue" while external implementation is "original" and can be very easily updated with only hash update. * This is especially important for security updates and reported CVEs - we have them for free and always updated with no additional work. * One thing to consider here is the 1. licensing (is it Apache??) and 2. software supply chain security (we may keep our local fork). Regarding nomenclature: * I like "CONFIG_BT*" prefix for all Bluetooth related. * Bluetooth in general would be enabled with `CONFIG_BT`. * I would then prefer `CONFIG_BT_ZBLUE` over `CONFIG_ZBLUE` because ZBlue jumps under the BT category. * Specific functionalities would then be provided by a selected implementation (i.e. zblue, nimble, nxbt) and could have overlappping names to provide the same "low level" stuff on their own - that would provide common API for the "higher level" user applications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
