JianyuWang0623 opened a new pull request, #3938:
URL: https://github.com/apache/nuttx-apps/pull/3938
## Summary
Coverity reports the `t1 < 0` / `t2 < 0` checks in the nxinit main loop as
dead code: init_service_refresh() and init_action_run_command() only return
non-negative wait times, and errors are handled by the ppoll() branch below.
Remove the two unreachable checks; behavior is unchanged.
## Impact
No behavior change: the removed branches were unreachable. No impact on
build, configuration, documentation, security, or compatibility.
## Testing
- Host: Ubuntu 22.04.5 LTS, x86_64, gcc 13.4.0
- Target: `sim:nsh` (apache/nuttx master + this patch; the defconfig
enables `CONFIG_SYSTEM_NXINIT=y`)
- Build: full build passes; all nxinit sources are compiled and linked.
- Runtime: sim boots to nsh; `uname -a`, `free` and `poweroff` work as
expected and the process exits with 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
