casaroli opened a new pull request, #3939: URL: https://github.com/apache/nuttx-apps/pull/3939
## Summary The Makefile and CMakeLists.txt of `interpreters/luamodules/luasyslog` defined `openlog()` and `closelog()` as macros for `lsyslog.c`. `<syslog.h>` already gives both, so these macros are not necessary. apache/nuttx#21128 makes `openlog()` and `closelog()` functions of libc; then the macros expand inside the declarations of `<syslog.h>`, and `lsyslog.c` does not compile. This PR removes the macros. `lsyslog.c` then uses `openlog()` and `closelog()` of `<syslog.h>`. ## Impact Only the build of the luasyslog Lua module (sim:lua). It works with the current `<syslog.h>` (macros) and with the new one (functions), so this PR can merge first. ## Testing sim:lua (macOS host) with this PR and apache/nuttx#21128 builds and links `lsyslog.c`. A file with the `openlog()`/`closelog()` calls of `lsyslog.c`, compiled without the macros against `<syslog.h>` of nuttx master and of apache/nuttx#21128: both compile. With the macros, it does not compile against apache/nuttx#21128. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
